From 53c2c1b1f5c168e5abd598e732d29b79116d78e7 Mon Sep 17 00:00:00 2001 From: tam1m Date: Sat, 3 Feb 2024 01:33:20 +0100 Subject: [PATCH 1/2] Remove KC_TRANS assignments for keys not existing on keyboards that do not define ANANLOG_MATRIX and or LK_WIRELESS_ENABLE. Assigning KC_TRANS here breaks NEW_SAFE_RANGE. Also fix typo in ANANLOG_MATRIX --- keyboards/keychron/common/keychron_common.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/keyboards/keychron/common/keychron_common.h b/keyboards/keychron/common/keychron_common.h index a155737a6c..86e42f62e5 100644 --- a/keyboards/keychron/common/keychron_common.h +++ b/keyboards/keychron/common/keychron_common.h @@ -37,21 +37,11 @@ enum { BT_HST3, P2P4G, BAT_LVL, -#else - BT_HST1 = _______, - BT_HST2 = _______, - BT_HST3 = _______, - P2P4G = _______, - BAT_LVL = _______, #endif -#ifdef DANANLOG_MATRIX +#ifdef ANANLOG_MATRIX PROF1, PROF2, PROF3, -#else - PROF1 = _______, - PROF2 = _______, - PROF3 = _______, #endif NEW_SAFE_RANGE, }; From 0cddb718d92c444e6e86f701f97a8f36a1e01d83 Mon Sep 17 00:00:00 2001 From: tam1m Date: Fri, 8 Mar 2024 15:34:26 +0100 Subject: [PATCH 2/2] Add defines for keychron custom keycodes when LK_WIRELESS_ENABLE and/or ANANLOG_MATRIX are not defined see: https://github.com/Keychron/qmk_firmware/pull/222/files#r1507606593 Co-authored-by: lokher --- keyboards/keychron/common/keychron_common.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/keyboards/keychron/common/keychron_common.h b/keyboards/keychron/common/keychron_common.h index 86e42f62e5..6f2147e78b 100644 --- a/keyboards/keychron/common/keychron_common.h +++ b/keyboards/keychron/common/keychron_common.h @@ -46,6 +46,19 @@ enum { NEW_SAFE_RANGE, }; +#ifndef LK_WIRELESS_ENABLE + #define BT_HST1 KC_TRANS + #define BT_HST2 KC_TRANS + #define BT_HST3 KC_TRANS + #define P2P4G KC_TRANS + #define BAT_LVL KC_TRANS +#endif +#ifndef ANANLOG_MATRIX + #define PROF1 KC_TRANS + #define PROF2 KC_TRANS + #define PROF3 KC_TRANS +#endif + #define KC_TASK KC_TASK_VIEW #define KC_FILE KC_FILE_EXPLORER #define KC_SNAP KC_SCREEN_SHOT