From 3f2f64cb8da2c27fcb7d491732956404aea36a25 Mon Sep 17 00:00:00 2001 From: Jose Gisbert <410091+lejouson@users.noreply.github.com> Date: Tue, 23 Apr 2024 18:28:46 +0200 Subject: [PATCH 1/2] Fix rotary encoder direction Fix direction in both default and navigation layers. --- .../splitkb/kyria/rev1/keymaps/lejouson/keymap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c b/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c index 9013fafd..87769b24 100644 --- a/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c +++ b/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c @@ -240,11 +240,11 @@ bool oled_task_user(void) { #ifdef ENCODER_ENABLE const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = { - [_DEFAULT ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(S(KC_TAB), KC_TAB ) }, - [ _NAVI ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(C(KC_LEFT), C(KC_RGHT)) }, - [_SYMBOLS ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [_FUNCTION] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [_NUMERIC ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [ _CONFIG ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_DEFAULT ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(KC_TAB, S(KC_TAB)) }, + [ _NAVI ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(C(KC_RGHT)), C(KC_LEFT) }, + [_SYMBOLS ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_FUNCTION] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_NUMERIC ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [ _CONFIG ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, }; #endif From 3782a4cf2a7e580b7db49532f8e4b8d5b5c94dda Mon Sep 17 00:00:00 2001 From: Jose Gisbert <410091+lejouson@users.noreply.github.com> Date: Tue, 23 Apr 2024 18:31:05 +0200 Subject: [PATCH 2/2] Fix use of parentheses --- .../splitkb/kyria/rev1/keymaps/lejouson/keymap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c b/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c index 87769b24..84c8be3e 100644 --- a/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c +++ b/keyboards/splitkb/kyria/rev1/keymaps/lejouson/keymap.c @@ -240,11 +240,11 @@ bool oled_task_user(void) { #ifdef ENCODER_ENABLE const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = { - [_DEFAULT ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(KC_TAB, S(KC_TAB)) }, - [ _NAVI ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(C(KC_RGHT)), C(KC_LEFT) }, - [_SYMBOLS ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [_FUNCTION] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [_NUMERIC ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, - [ _CONFIG ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_DEFAULT ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(KC_TAB, S(KC_TAB) ) }, + [ _NAVI ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(C(KC_RGHT), C(KC_LEFT)) }, + [_SYMBOLS ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_FUNCTION] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [_NUMERIC ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, + [ _CONFIG ] = { ENCODER_CCW_CW(XXXXXXX, XXXXXXX), ENCODER_CCW_CW(_______, _______ ) }, }; #endif