From c3d200d53df3f62735e59fc6512c7fb700a1fba9 Mon Sep 17 00:00:00 2001 From: Albert Y <76888457+filterpaper@users.noreply.github.com> Date: Mon, 12 Dec 2022 23:52:22 +0800 Subject: [PATCH] [Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007) * Replace Tapping Force Hold feature with Quick Tap Term * Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0 * Deprecate force hold in info_config.json * Before and after quick tap term unit tests * Quick tap unit tests iteration * Keymap config.h correction * Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed * Add two more test cases for quick tap * Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2 * Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2 * Add function declaration for get_quick_tap_term Co-authored-by: Stefan Kerkmann --- keyboards/basekeys/slice/rev1/keymaps/via/config.h | 2 +- keyboards/gl516/n51gl/keymaps/via/config.h | 2 +- keyboards/lily58/keymaps/via/config.h | 2 +- keyboards/malevolti/lyra/keymaps/via/config.h | 2 +- keyboards/malevolti/superlyra/keymaps/via/config.h | 2 +- keyboards/pinky/3/keymaps/via/config.h | 2 +- keyboards/pinky/4/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/7splus/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/ajisai74/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/ergoarrows/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/naked48/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/naked60/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/nknl7en/keymaps/via/config.h | 2 +- keyboards/salicylic_acid3/nknl7jp/keymaps/via/config.h | 2 +- keyboards/sparrow62/keymaps/via/config.h | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/keyboards/basekeys/slice/rev1/keymaps/via/config.h b/keyboards/basekeys/slice/rev1/keymaps/via/config.h index 3dc07fda..f1d6eef4 100644 --- a/keyboards/basekeys/slice/rev1/keymaps/via/config.h +++ b/keyboards/basekeys/slice/rev1/keymaps/via/config.h @@ -18,5 +18,5 @@ along with this program. If not, see . /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/gl516/n51gl/keymaps/via/config.h b/keyboards/gl516/n51gl/keymaps/via/config.h index fd96baa8..0e221d84 100644 --- a/keyboards/gl516/n51gl/keymaps/via/config.h +++ b/keyboards/gl516/n51gl/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/lily58/keymaps/via/config.h b/keyboards/lily58/keymaps/via/config.h index a5dfe7c8..331521bc 100644 --- a/keyboards/lily58/keymaps/via/config.h +++ b/keyboards/lily58/keymaps/via/config.h @@ -28,7 +28,7 @@ along with this program. If not, see . // #define MASTER_RIGHT // #define EE_HANDS -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 100 // Underglow diff --git a/keyboards/malevolti/lyra/keymaps/via/config.h b/keyboards/malevolti/lyra/keymaps/via/config.h index 9c4bacd3..3e8db641 100644 --- a/keyboards/malevolti/lyra/keymaps/via/config.h +++ b/keyboards/malevolti/lyra/keymaps/via/config.h @@ -26,5 +26,5 @@ along with this program. If not, see . // #define MASTER_RIGHT // #define EE_HANDS -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 100 diff --git a/keyboards/malevolti/superlyra/keymaps/via/config.h b/keyboards/malevolti/superlyra/keymaps/via/config.h index bbdf4746..7f20fea8 100644 --- a/keyboards/malevolti/superlyra/keymaps/via/config.h +++ b/keyboards/malevolti/superlyra/keymaps/via/config.h @@ -22,5 +22,5 @@ along with this program. If not, see . -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 100 diff --git a/keyboards/pinky/3/keymaps/via/config.h b/keyboards/pinky/3/keymaps/via/config.h index 63e8168b..3671c13a 100644 --- a/keyboards/pinky/3/keymaps/via/config.h +++ b/keyboards/pinky/3/keymaps/via/config.h @@ -24,6 +24,6 @@ // #define MASTER_RIGHT // #define EE_HANDS -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 200 #define RETRO_TAPPPING diff --git a/keyboards/pinky/4/keymaps/via/config.h b/keyboards/pinky/4/keymaps/via/config.h index 63e8168b..3671c13a 100644 --- a/keyboards/pinky/4/keymaps/via/config.h +++ b/keyboards/pinky/4/keymaps/via/config.h @@ -24,6 +24,6 @@ // #define MASTER_RIGHT // #define EE_HANDS -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 200 #define RETRO_TAPPPING diff --git a/keyboards/salicylic_acid3/7splus/keymaps/via/config.h b/keyboards/salicylic_acid3/7splus/keymaps/via/config.h index 8a89da2e..83e6f1b1 100644 --- a/keyboards/salicylic_acid3/7splus/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/7splus/keymaps/via/config.h @@ -18,6 +18,6 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 #define DYNAMIC_KEYMAP_LAYER_COUNT 3 diff --git a/keyboards/salicylic_acid3/ajisai74/keymaps/via/config.h b/keyboards/salicylic_acid3/ajisai74/keymaps/via/config.h index 81ee8ef7..8a42af51 100644 --- a/keyboards/salicylic_acid3/ajisai74/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/ajisai74/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/salicylic_acid3/ergoarrows/keymaps/via/config.h b/keyboards/salicylic_acid3/ergoarrows/keymaps/via/config.h index fd96baa8..0e221d84 100644 --- a/keyboards/salicylic_acid3/ergoarrows/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/ergoarrows/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/salicylic_acid3/naked48/keymaps/via/config.h b/keyboards/salicylic_acid3/naked48/keymaps/via/config.h index fd96baa8..0e221d84 100644 --- a/keyboards/salicylic_acid3/naked48/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/naked48/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/salicylic_acid3/naked60/keymaps/via/config.h b/keyboards/salicylic_acid3/naked60/keymaps/via/config.h index 32ec5281..f90e8028 100644 --- a/keyboards/salicylic_acid3/naked60/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/naked60/keymaps/via/config.h @@ -18,6 +18,6 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 #define DYNAMIC_KEYMAP_LAYER_COUNT 3 diff --git a/keyboards/salicylic_acid3/nknl7en/keymaps/via/config.h b/keyboards/salicylic_acid3/nknl7en/keymaps/via/config.h index fd96baa8..0e221d84 100644 --- a/keyboards/salicylic_acid3/nknl7en/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/nknl7en/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/salicylic_acid3/nknl7jp/keymaps/via/config.h b/keyboards/salicylic_acid3/nknl7jp/keymaps/via/config.h index fd96baa8..0e221d84 100644 --- a/keyboards/salicylic_acid3/nknl7jp/keymaps/via/config.h +++ b/keyboards/salicylic_acid3/nknl7jp/keymaps/via/config.h @@ -18,5 +18,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180 diff --git a/keyboards/sparrow62/keymaps/via/config.h b/keyboards/sparrow62/keymaps/via/config.h index 15eb08ed..e1fae611 100644 --- a/keyboards/sparrow62/keymaps/via/config.h +++ b/keyboards/sparrow62/keymaps/via/config.h @@ -19,5 +19,5 @@ /* Select hand configuration */ -#define TAPPING_FORCE_HOLD +#define QUICK_TAP_TERM 0 #define TAPPING_TERM 180